[PATCH 06/10] drm/ast: dp501: Avoid upcasting to struct ast_device

[Thomas Zimmermann]

Hi

Am 12.09.24 um 15:48 schrieb Jocelyn Falempe:
[...]
>> --- a/drivers/gpu/drm/ast/ast_main.c
>> +++ b/drivers/gpu/drm/ast/ast_main.c
>> @@ -110,7 +110,7 @@ static void ast_detect_tx_chip(struct ast_device 
>> *ast, bool need_post)
>>               ast->dp501_fw_addr = drmm_kzalloc(dev, 32*1024, 
>> GFP_KERNEL);
>>               if (ast->dp501_fw_addr) {
>>                   /* backup firmware */
>> -                if (ast_backup_fw(dev, ast->dp501_fw_addr, 32*1024)) {
>> +                if (ast_backup_fw(ast, ast->dp501_fw_addr, 32*1024)) {
>
> Maybe we can remove the fw_addr parameter of ast_backup_fw(), it's the 
> only call to this function.

I don't mind, but it belongs in a separate patchset. After doing 
something about the odd TX chips that we talked about, I intent to 
rework the TX- and GPU-POST code.

Best regards
Thomas

>
>>                       drmm_kfree(dev, ast->dp501_fw_addr);
>>                       ast->dp501_fw_addr = NULL;
>>                   }
>> diff --git a/drivers/gpu/drm/ast/ast_post.c 
>> b/drivers/gpu/drm/ast/ast_post.c
>> index 902bf8114b6e..324778c72d23 100644
>> --- a/drivers/gpu/drm/ast/ast_post.c
>> +++ b/drivers/gpu/drm/ast/ast_post.c
>> @@ -360,7 +360,7 @@ void ast_post_gpu(struct drm_device *dev)
>>           else
>>               ast_init_dram_reg(dev);
>>   -        ast_init_3rdtx(dev);
>> +        ast_init_3rdtx(ast);
>>       } else {
>>           if (ast->tx_chip == AST_TX_SIL164)
>>               ast_set_index_reg_mask(ast, AST_IO_VGACRI, 0xa3, 0xcf, 
>> 0x80);    /* Enable DVO */
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)