[PATCH v6 3/3] drm/rockchip: Add basic RK3588 HDMI output support

Heiko Stuebner heiko at sntech.de
Sun Sep 15 06:13:53 UTC 2024


Am Samstag, 14. September 2024, 20:28:59 CEST schrieb Cristian Ciocaltea:
> On 9/10/24 10:08 PM, Heiko Stübner wrote:
> > Am Freitag, 6. September 2024, 03:17:42 CEST schrieb Cristian Ciocaltea:

> > That hdmi->ref_clk just accidentially falls out of that loop at the end
> > looks somewhat strange, so getting and keeping that refclk
> > separately would make this look cleaner.
> 
> I've added /* keep "ref" last */ comment above, but I agree it's not really
> the best approach.
> 
> I'm going to submit v7 in the meantime, as this was the last remaining open
> topic on my list.  I guess we can figure this out afterwards.

yep, that is fine to figure out later, as it's mainly a style thing.




More information about the dri-devel mailing list