[PATCH v4 1/8] dt-bindings: connector: add GE SUNH hotplug addon connector
Rob Herring (Arm)
robh at kernel.org
Tue Sep 17 10:29:51 UTC 2024
On Tue, 17 Sep 2024 10:53:05 +0200, Luca Ceresoli wrote:
> Add bindings for the GE SUNH add-on connector. This is a physical,
> hot-pluggable connector that allows to attach and detach at runtime an
> add-on adding peripherals on non-discoverable busses.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli at bootlin.com>
>
> ---
>
> Changed in v4:
> - rename 'nobus-devices' to 'devices'
> - use 'additionalProperties: true' for the 'devices' node (nodes are added
> by overlays)
> - document GPIO polarity
> - add '|' for descriptions to preserve line breaks
> - remove powergood-gpios (removed in hardware design)
> - Omit "/" node, not needed and cause of warnings
> - remove reference to v2 examples from example comment
> - remove unneeded "addon_connector" label from example
>
> Changed in v3:
> - change the layout to only add subnodes, not properties
> - add the 'nobus-devices' node description to hold devices not on any bus
> - add 'i2c-*' nodes for the I2C busses, using a i2c-parent phandle
> - and the 'dsi' node for the DSI bus
> - move the entire port at 1 node to the overlay (not only the remote-endpoint
> property)
> - remove the overlay examples (Overlays in examples are not supported)
> - add more clarifying descriptions and comments for examples
> - some rewording
>
> This patch was added in v2.
> ---
> .../connector/ge,sunh-addon-connector.yaml | 177 +++++++++++++++++++++
> MAINTAINERS | 5 +
> 2 files changed, 182 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/connector/ge,sunh-addon-connector.example.dtb: addon-connector: Unevaluated properties are not allowed ('powergood-gpios' was unexpected)
from schema $id: http://devicetree.org/schemas/connector/ge,sunh-addon-connector.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240917-hotplug-drm-bridge-v4-1-bc4dfee61be6@bootlin.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
More information about the dri-devel
mailing list