[PATCH v6 02/12] spi: intel-dg: implement region enumeration
Winkler, Tomas
tomas.winkler at intel.com
Thu Sep 19 09:55:54 UTC 2024
>
> On Mon, Sep 16, 2024 at 04:49:18PM +0300, Alexander Usyskin wrote:
>
> > In intel-dg spi, there is no access to the spi controller, the
> > information is extracted from the descriptor region.
>
> Which information? I can't tell what this patch is supposed to do; as with the
> first patch this shouldn't be standalone.
The patch series was built for review, it adds functionality on top of each other.
>
> > +static inline u32 spi_error(struct intel_dg_spi *spi) {
>
> > +static inline u32 spi_read32(struct intel_dg_spi *spi, u32 address) {
>
> At least these names are too generic, please use driver specific prefixes.
Can be done but those functions are local to the driver not part of the API.
More information about the dri-devel
mailing list