[PATCH v4 23/27] arm64: dts: qcom: starqltechn: add display PMIC

[Krzysztof Kozlowski]

On 19/09/2024 15:17, Dzmitry Sankouski wrote:
>>> +             pmic at 60 {
>>> +                     compatible = "samsung,s2dos05";
>>> +                     reg = <0x60>;
>>> +
>>> +                     regulators {
>>> +                             s2dos05_ldo1: ldo1 {
>>> +                                     regulator-active-discharge = <1>;
>>> +                                     regulator-enable-ramp-delay = <12000>;
>>> +                                     regulator-min-microvolt = <1500000>;
>>> +                                     regulator-max-microvolt = <2000000>;
>>> +                                     regulator-name = "s2dos05-ldo1";
>>
>> Useless name. Please use rather names from the schematics, but I guess
>> you might not have them, so maybe downstream has reasonable name?
> 
> Unfortunately, downstream uses that same name.

Then "ldo1" is enough.

Best regards,
Krzysztof