[PATCH] drm/vkms: Add missing check for CRTC initialization
Maíra Canal
mcanal at igalia.com
Wed Sep 25 00:02:18 UTC 2024
Hi Louis,
On 9/6/24 13:15, Louis Chauvet wrote:
> CRTC initialization call drm_mode_crtc_set_gamma_size without the proper
> checks, introduce this check to avoid issues.
>
> Signed-off-by: Louis Chauvet <louis.chauvet at bootlin.com>
Applied to misc/kernel.git (drm-misc-next).
Best Regards,
- Maíra
> ---
> drivers/gpu/drm/vkms/vkms_crtc.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
> index 40b4d084e3ce..e4f93dfbd071 100644
> --- a/drivers/gpu/drm/vkms/vkms_crtc.c
> +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> @@ -287,7 +287,12 @@ int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc,
>
> drm_crtc_helper_add(crtc, &vkms_crtc_helper_funcs);
>
> - drm_mode_crtc_set_gamma_size(crtc, VKMS_LUT_SIZE);
> + ret = drm_mode_crtc_set_gamma_size(crtc, VKMS_LUT_SIZE);
> + if (ret) {
> + DRM_ERROR("Failed to set gamma size\n");
> + return ret;
> + }
> +
> drm_crtc_enable_color_mgmt(crtc, 0, false, VKMS_LUT_SIZE);
>
> spin_lock_init(&vkms_out->lock);
>
> ---
> base-commit: a6bb1f77a94335de67dba12e7f52651c115b82d2
> change-id: 20240906-vkms-add-missing-check-e1b6ee8d1b39
>
> Best regards,
More information about the dri-devel
mailing list