[PATCH v5 10/10] drm/tiny: add driver for Apple Touch Bars in x86 Macs

[mripard at kernel.org]

On Sat, Aug 17, 2024 at 11:52:22AM GMT, Aditya Garg wrote:
> From: Kerem Karabay <kekrby at gmail.com>
> 
> The Touch Bars found on x86 Macs support two USB configurations: one
> where the device presents itself as a HID keyboard and can display
> predefined sets of keys, and one where the operating system has full
> control over what is displayed. This commit adds support for the display
> functionality of the second configuration.
> 
> Note that this driver has only been tested on T2 Macs, and only includes
> the USB device ID for these devices. Testing on T1 Macs would be
> appreciated.
> 
> Credit goes to @imbushuo on GitHub for reverse engineering most of the
> protocol.
> 
> Signed-off-by: Kerem Karabay <kekrby at gmail.com>
> Signed-off-by: Aditya Garg <gargaditya08 at live.com>
> ---
>  MAINTAINERS                       |   6 +
>  drivers/gpu/drm/tiny/Kconfig      |  12 +
>  drivers/gpu/drm/tiny/Makefile     |   1 +
>  drivers/gpu/drm/tiny/appletbdrm.c | 624 ++++++++++++++++++++++++++++++
>  4 files changed, 643 insertions(+)
>  create mode 100644 drivers/gpu/drm/tiny/appletbdrm.c
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8766f3e5e..2665e6c57 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6889,6 +6889,12 @@ S:	Supported
>  T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
>  F:	drivers/gpu/drm/sun4i/sun8i*
>  
> +DRM DRIVER FOR APPLE TOUCH BARS
> +M:	Kerem Karabay <kekrby at gmail.com>
> +L:	dri-devel at lists.freedesktop.org
> +S:	Maintained
> +F:	drivers/gpu/drm/tiny/appletbdrm.c

How do you plan on maintaining it? If you want to do so through drm-misc
(and you should), you need to list the gitlab repo here.

Also, I haven't seen Kerem take part of the discussion at all. Are they
ok with taking on the maintainer's role?

It's really clear to me either why this needs to be going through hid at
all. Is it not standalone?

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 273 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20240927/b3924085/attachment.sig>