[PATCH v8 1/3] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library

Maxime Ripard mripard at kernel.org
Mon Sep 30 07:44:51 UTC 2024


On Sun, Sep 29, 2024 at 01:36:47AM GMT, Cristian Ciocaltea wrote:
> +static enum drm_mode_status
> +dw_hdmi_qp_bridge_mode_valid(struct drm_bridge *bridge,
> +			     const struct drm_display_info *info,
> +			     const struct drm_display_mode *mode)
> +{
> +	struct dw_hdmi_qp *hdmi = bridge->driver_private;
> +
> +	if (mode->clock > HDMI14_MAX_TMDSCLK / 1000) {
> +		dev_dbg(hdmi->dev, "Unsupported mode clock: %d\n", mode->clock);
> +		return MODE_CLOCK_HIGH;
> +	}

Similarly, you should use drm_hdmi_compute_mode_clock here, with RGB and 8bpc

Once fixed,
Reviewed-by: Maxime Ripard <mripard at kernel.org>

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 273 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20240930/5d8dbf1b/attachment-0001.sig>


More information about the dri-devel mailing list