linux-6.12-rc1/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c:653: Possible &/&& mixup ?

[David Binderman]

Hello there,

Static analyser cppcheck says:

linux-6.12-rc1/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c:653:19: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]

Source code is

    if (!surf_linear & (log2_dpte_req_height_ptes == 0) & surf_vert) //reduced, in this case, will have page fault within a group

IMHO, looks odd. Was && intended ?

Regards

David Binderman