[PATCH 20/29] accel/ivpu: Prevent recovery invocation during probe and resume

Jacek Lawrynowicz jacek.lawrynowicz at linux.intel.com
Mon Sep 30 19:45:22 UTC 2024


On 9/27/2024 11:28 PM, Jeffrey Hugo wrote:
> On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote:
>> From: Karol Wachowski <karol.wachowski at intel.com>
>>
>> Refactor IPC send and receive functions to allow correct
>> handling of operations that should not trigger a recovery process.
>>
>> Expose ivpu_send_receive_internal(), which is now utilized by the D0i3
>> entry, DCT initialization, and HWS initialization functions.
>> These functions have been modified to return error codes gracefully,
>> rather than initiating recovery.
>>
>> The updated functions are invoked within ivpu_probe() and ivpu_resume(),
>> ensuring that any errors encountered during these stages result in a proper
>> teardown or shutdown sequence. The previous approach of triggering recovery
>> within these functions could lead to a race condition, potentially causing
>> undefined behavior and kernel crashes due to null pointer dereferences.
> 
> Fixing possible kernel panics, sounds like a great idea. Should have a fixes tag through?

OK


More information about the dri-devel mailing list