[PATCH 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

[Krzysztof Kozlowski]

On Wed, Apr 02, 2025 at 08:12:11AM +0200, Marcus Folkesson wrote:
> +
> +static void st7571_reset(struct st7571_device *st7571)
> +{
> +	gpiod_set_value_cansleep(st7571->reset, 0);
> +	mdelay(20);
> +	gpiod_set_value_cansleep(st7571->reset, 1);

huh? Why do you keep reset ACTIVE after performing reset? This makes no
sense, unless you just put wrong flags into your DTS. Your binding
already suggest that - you claim this is N signal, but use high flag.

> +}
> +
> +static int st7571_initialize(struct st7571_device *st7571)
> +{
> +	/*
> +	 * Most of the initialization sequence is taken directly from the
> +	 * referential initial code in the ST7571 datasheet.

Best regards,
Krzysztof