[PATCH v3 5/5] drm/panthor: Don't update MMU_INT_MASK in panthor_mmu_irq_handler()

Boris Brezillon boris.brezillon at collabora.com
Fri Apr 4 08:09:33 UTC 2025


Interrupts are automatically unmasked in
panthor_mmu_irq_threaded_handler() when the handler returns. Unmasking
prematurely might generate spurious interrupts if the IRQ line is
shared.

Changes in v2:
- New patch

Changes in v3:
- Add R-bs

Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Liviu Dudau <liviu.dudau at arm.com>
Reviewed-by: Steven Price <steven.price at arm.com>
---
 drivers/gpu/drm/panthor/panthor_mmu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
index 0ba76982d45b..dc173c6edde0 100644
--- a/drivers/gpu/drm/panthor/panthor_mmu.c
+++ b/drivers/gpu/drm/panthor/panthor_mmu.c
@@ -1721,7 +1721,6 @@ static void panthor_mmu_irq_handler(struct panthor_device *ptdev, u32 status)
 		 * re-enabled.
 		 */
 		ptdev->mmu->irq.mask = new_int_mask;
-		gpu_write(ptdev, MMU_INT_MASK, new_int_mask);
 
 		if (ptdev->mmu->as.slots[as].vm)
 			ptdev->mmu->as.slots[as].vm->unhandled_fault = true;
-- 
2.49.0



More information about the dri-devel mailing list