[PATCH 2/2] accel/ivpu: Show NPU frequency in sysfs

[Jeff Hugo]

On 4/1/2025 9:59 AM, Maciej Falkowski wrote:
> From: Andrzej Kacprowski <Andrzej.Kacprowski at intel.com>
> 
> Add sysfs files that show maximum and current
> frequency of the NPU's data processing unit.
> New sysfs entries:
> - npu_max_frequency_mhz

Don't you have an ioctl to get this, which is fixed in patch 1 of the 
series?  Why duplicate that with a sysfs?

> - npu_current_frequency_mhz

Do you have userspace code that consumes these?

> 
> Signed-off-by: Andrzej Kacprowski <Andrzej.Kacprowski at intel.com>
> Signed-off-by: Maciej Falkowski <maciej.falkowski at linux.intel.com>
> ---
>   drivers/accel/ivpu/ivpu_hw.h      |  5 ++++
>   drivers/accel/ivpu/ivpu_hw_btrs.c |  8 +++++
>   drivers/accel/ivpu/ivpu_hw_btrs.h |  1 +
>   drivers/accel/ivpu/ivpu_sysfs.c   | 49 ++++++++++++++++++++++++++++++-

Missing uapi documentation.

Also, should the sysfs maintainers be included in the review?