[PATCH v2 1/3] dt-bindings: display: Add Sitronix ST7571 panel
Krzysztof Kozlowski
krzk at kernel.org
Fri Apr 4 17:36:12 UTC 2025
On 04/04/2025 19:30, Krzysztof Kozlowski wrote:
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/gpio/gpio.h>
>> +
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + display at 3f {
>
> Not much improved. How is this called in every other binding? panel.
Hmmm, unless this is not a panel, but it looks like a panel and
description partially suggests it. Other sitronix devices are split
between these two, but OTOH your driver is more complex than just simple
panel.
Your commit msg is one sentence and binding description is basically
non-existing, so not sure how to help. You need to describe the hardware
so people understand what this device is.
Best regards,
Krzysztof
More information about the dri-devel
mailing list