[PATCH] drm: renesas: Add zpos, alpha and blend properties to RZ/G2L DU

[Biju Das]

Hi Laurent,

> -----Original Message-----
> From: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Sent: 04 April 2025 21:57
> Subject: Re: [PATCH] drm: renesas: Add zpos, alpha and blend properties to RZ/G2L DU
> 
> Hi Biju,
> 
> Thank you for the patch.
> 
> On Fri, Apr 04, 2025 at 02:30:45PM +0100, Biju Das wrote:
> > Add support for zpos, alpha and blend properties to RZ/G2L DU driver
> > as the IP supports all these properties.
> >
> > It is tested by the below modetest commands:
> >
> > modetest -M rzg2l-du -s 44 at 42:1920x1080 at AR24 -d -P \
> > 37 at 42:512x300+200+200 at XR15
> >
> > modetest -M rzg2l-du -w {32,37}:alpha:{0,65535} modetest -M rzg2l-du
> > -w {32,37}:zpos:{0,1}
> >
> > Signed-off-by: Biju Das <biju.das.jz at bp.renesas.com>
> > ---
> >  drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c
> > b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c
> > index 8643ff2eec46..040d4e4aff00 100644
> > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c
> > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c
> > @@ -340,6 +340,15 @@ int rzg2l_du_vsp_init(struct rzg2l_du_vsp *vsp,
> > struct device_node *np,
> >
> >  		drm_plane_helper_add(&plane->plane,
> >  				     &rzg2l_du_vsp_plane_helper_funcs);
> > +
> > +		drm_plane_create_alpha_property(&plane->plane);
> > +		drm_plane_create_zpos_property(&plane->plane, i, 0,
> > +					       num_planes - 1);
> > +
> > +		drm_plane_create_blend_mode_property(&plane->plane,
> > +					BIT(DRM_MODE_BLEND_PIXEL_NONE) |
> > +					BIT(DRM_MODE_BLEND_PREMULTI) |
> > +					BIT(DRM_MODE_BLEND_COVERAGE));
> 
> It's interesting that the driver already handles the alpha, zpos and blend mode properties set in the
> state, but doesn't expose those properties to userspace.

Yes, somehow missed adding alpha, zpos and blend property.

Cheers,
Biju

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> 
> >  	}
> >
> >  	return 0;
> 
> --
> Regards,
> 
> Laurent Pinchart