[PATCH 1/3] drm/panel: auo-a030jtn01: Fix compilation build

Thomas Zimmermann tzimmermann at suse.de
Tue Apr 8 13:20:26 UTC 2025


Hi Maxime

thanks for the fixes

Am 08.04.25 um 14:20 schrieb Maxime Ripard:
> Commit 9d7d7c3c9a19 ("panel/auo-a030jtn01: Use refcounted allocation in
> place of devm_kzalloc()") switched from a kmalloc + drm_panel_init call
> to a devm_drm_panel_alloc one.
>
> However, the variable it was storing the allocated pointer in doesn't
> exist, resulting in a compilation breakage.
>
> Fixes: 9d7d7c3c9a19 ("panel/auo-a030jtn01: Use refcounted allocation in place of devm_kzalloc()")
> Signed-off-by: Maxime Ripard <mripard at kernel.org>

On this series

Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>

And as far as the build error is concerned:

Tested-by: Thomas Zimmermann <tzimmermann at suse.de>

Best regards
Thomas



> ---
>   drivers/gpu/drm/panel/panel-auo-a030jtn01.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-auo-a030jtn01.c b/drivers/gpu/drm/panel/panel-auo-a030jtn01.c
> index 83529b1c2bac..6e52bf6830e1 100644
> --- a/drivers/gpu/drm/panel/panel-auo-a030jtn01.c
> +++ b/drivers/gpu/drm/panel/panel-auo-a030jtn01.c
> @@ -198,14 +198,14 @@ static int a030jtn01_probe(struct spi_device *spi)
>   	struct a030jtn01 *priv;
>   	int err;
>   
>   	spi->mode |= SPI_MODE_3 | SPI_3WIRE;
>   
> -	panel = devm_drm_panel_alloc(dev, struct a030jtn01, panel,
> -				     &a030jtn01_funcs, DRM_MODE_CONNECTOR_DPI);
> -	if (IS_ERR(panel))
> -		return PTR_ERR(panel);
> +	priv = devm_drm_panel_alloc(dev, struct a030jtn01, panel,
> +				    &a030jtn01_funcs, DRM_MODE_CONNECTOR_DPI);
> +	if (IS_ERR(priv))
> +		return PTR_ERR(priv);
>   
>   	priv->spi = spi;
>   	spi_set_drvdata(spi, priv);
>   
>   	priv->map = devm_regmap_init_spi(spi, &a030jtn01_regmap_config);

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)



More information about the dri-devel mailing list