[PATCH v5 3/4] drm/panthor: Label all kernel BO's
Boris Brezillon
boris.brezillon at collabora.com
Wed Apr 9 08:05:07 UTC 2025
On Tue, 8 Apr 2025 23:24:23 +0100
Adrián Larumbe <adrian.larumbe at collabora.com> wrote:
> Kernel BO's aren't exposed to UM, so labelling them is the responsibility
> of the driver itself. This kind of tagging will prove useful in further
> commits when want to expose these objects through DebugFS.
>
> Expand panthor_kernel_bo_create() interface to take a NULL-terminated
> string. No bounds checking is done because all label strings are given
> as statically-allocated literals, but if a more complex kernel BO naming
> scheme with explicit memory allocation and formatting was desired in the
> future, this would have to change.
>
> Signed-off-by: Adrián Larumbe <adrian.larumbe at collabora.com>
Just one modification suggested on a label, but this looks good
otherwise
Reviewed-by: Boris Brezillon <boris.brezillon at collabora.com>
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 8 +++++---
> drivers/gpu/drm/panthor/panthor_gem.c | 4 +++-
> drivers/gpu/drm/panthor/panthor_gem.h | 2 +-
> drivers/gpu/drm/panthor/panthor_heap.c | 6 ++++--
> drivers/gpu/drm/panthor/panthor_sched.c | 9 ++++++---
> 5 files changed, 19 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c
> index 1a276db095ff..432a8993a0cb 100644
> --- a/drivers/gpu/drm/panthor/panthor_sched.c
> +++ b/drivers/gpu/drm/panthor/panthor_sched.c
> @@ -3334,7 +3334,8 @@ group_create_queue(struct panthor_group *group,
> DRM_PANTHOR_BO_NO_MMAP,
> DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC |
> DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED,
> - PANTHOR_VM_KERNEL_AUTO_VA);
> + PANTHOR_VM_KERNEL_AUTO_VA,
> + "Ring buffer");
"CS ring buffer"
> if (IS_ERR(queue->ringbuf)) {
> ret = PTR_ERR(queue->ringbuf);
> goto err_free_queue;
More information about the dri-devel
mailing list