[bug report] HACK: drm/panel: ltk050h3146w: read panel-id
Dan Carpenter
dan.carpenter at linaro.org
Wed Apr 9 10:59:39 UTC 2025
Hello Heiko Stuebner,
Commit e09be2a6ab1a ("HACK: drm/panel: ltk050h3146w: read panel-id")
from Mar 26, 2025 (linux-next), leads to the following Smatch static
checker warning:
drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c:490 ltk050h314x_read_id()
warn: inconsistent indenting
drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
477 static int ltk050h314x_read_id(struct mipi_dsi_multi_context *dsi_ctx) {
478 // struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
479 u8 id[3] = {0};
480 int ret;
481
482 /* ILI988D requires a page 1 select to return stable results for register 4
483 * HX8394-F ignores this command */
484 ltk050h3146w_a2_select_page(dsi_ctx, 1);
485
486 ret = mipi_dsi_dcs_read(dsi_ctx->dsi, 0x04, id, ARRAY_SIZE(id));
487 if (ret < 0)
488 return ret;
489
--> 490 printk("%s: %u %u %u\n", __func__, id[0], id[1], id[2]);
It looks like debug code escaped. Although this might also have been
intentional based on the HACK in the summary.
491 return (id[0] << 16) | (id[1] << 8) | (id[2] << 0);
492 }
493
494 static int ltk050h3146w_prepare(struct drm_panel *panel)
495 {
regards,
dan carpenter
More information about the dri-devel
mailing list