[PATCH v4 0/2] drm/panthor: Add 64-bit register accessors

Karunika Choo karunika.choo at arm.com
Thu Apr 17 12:37:23 UTC 2025


Hi all,

This patch series adds support for 64-bit and poll register accessors in
the Panthor DRM driver and performs a cleanup of the 64-bit register
definitions.

The first patch introduces new accessor functions to simplify and
standardize 64-bit and polling register operations. The second patch
refactors the existing 64-bit register definitions for improved clarity
and consistency.

v4:
- [PATCH 1/2]:
  - Fixed missing check against mask value in PWRTRANS register polling.
  - Removed panthor_gpu_read_timestamp() and
    panthor_gpu_read_timestamp_offset() in favour of direct register
    access as they currently only serve as wrapper functions.
- [PATCH 2/2]:
  - Updated the register names inline with the removal of the two
    timestamp functions.
- Picked up Rb tags from Liviu and Steven
- Link to v3: https://lore.kernel.org/dri-devel/20250411164805.2015088-1-karunika.choo@arm.com/
v3:
- Picked up Rb tags from Boris.
- Link to v2: https://lore.kernel.org/dri-devel/20250411151140.1815435-1-karunika.choo@arm.com/
v2:
- Updated padding of the poll functions as requested
- Removed *_HI register definitions and renamed *_LO registers
- Link to v1: https://lore.kernel.org/dri-devel/20250410163546.919749-1-karunika.choo@arm.com/

Kind regards,
Karunika Choo

Karunika Choo (2):
  drm/panthor: Add 64-bit and poll register accessors
  drm/panthor: Clean up 64-bit register definitions

 drivers/gpu/drm/panthor/panthor_device.h |  71 ++++++++++
 drivers/gpu/drm/panthor/panthor_drv.c    |   4 +-
 drivers/gpu/drm/panthor/panthor_fw.c     |   9 +-
 drivers/gpu/drm/panthor/panthor_gpu.c    | 159 +++++------------------
 drivers/gpu/drm/panthor/panthor_gpu.h    |  12 +-
 drivers/gpu/drm/panthor/panthor_mmu.c    |  34 ++---
 drivers/gpu/drm/panthor/panthor_regs.h   | 100 +++++---------
 7 files changed, 162 insertions(+), 227 deletions(-)

-- 
2.47.1



More information about the dri-devel mailing list