[PATCH v2 15/15] drm: renesas: rz-du: mipi_dsi: Add support for RZ/V2H(P) SoC

[Lad, Prabhakar]

Hi Geert,

Thank you for the review.

On Wed, Apr 16, 2025 at 10:35 AM Geert Uytterhoeven
<geert at linux-m68k.org> wrote:
>
> Hi Prabhakar, Fabrizio,
>
> On Tue, 8 Apr 2025 at 22:09, Prabhakar <prabhakar.csengg at gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj at bp.renesas.com>
> >
> > Add DSI support for Renesas RZ/V2H(P) SoC.
> >
> > Co-developed-by: Fabrizio Castro <fabrizio.castro.jz at renesas.com>
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz at renesas.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj at bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> > @@ -70,6 +80,18 @@ struct rzg2l_mipi_dsi {
> >         unsigned int num_data_lanes;
> >         unsigned int lanes;
> >         unsigned long mode_flags;
> > +
> > +       struct rzv2h_dsi_mode_calc mode_calc;
> > +       struct rzv2h_plldsi_parameters dsi_parameters;
> > +};
> > +
> > +static const struct rzv2h_plldsi_div_limits rzv2h_plldsi_div_limits = {
> > +       .m = { .min = 64, .max = 1023 },
>
> .max = 533?
>
> > +       .p = { .min = 1, .max = 4 },
> > +       .s = { .min = 0, .max = 5 },
>
> .max = 6?
>
> > +       .k = { .min = -32768, .max = 32767 },
> > +       .csdiv = { .min = 1, .max = 1 },
> > +       .fvco = { .min = 1050 * MEGA, .max = 2100 * MEGA }
> >  };
>
> Summarized: why do these values differ from the ones in the declaration
> macro RZV2H_CPG_PLL_DSI_LIMITS(), i.e. why can't you use the latter?
>
There is a divider inside the DSI IP which is almost similar to PLL in
the CPG. The divider limits for the DSI IP vary as compared to one in
the CPG IP.

Cheers,
Prabhakar