[PATCH] drm/ttm: fix the warning for hit_low and evict_low

Khatri, Sunil sukhatri at amd.com
Mon Apr 21 11:23:44 UTC 2025


@Lankhorst
Does the comment sounds correct or could you please share what should be 
the right comment to add

Regards
Sunil Khatri

On 4/21/2025 4:49 PM, Sunil Khatri wrote:
> fix the below warning messages:
> ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'hit_low' not described in 'ttm_bo_swapout_walk'
> ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'evict_low' not described in 'ttm_bo_swapout_walk'
>
> Cc: Maarten Lankhorst <dev at lankhorst.se>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
> Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>
> ---
>   drivers/gpu/drm/ttm/ttm_bo.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 95b86003c50d..5bf3c969907c 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1093,7 +1093,8 @@ struct ttm_bo_swapout_walk {
>   	struct ttm_lru_walk walk;
>   	/** @gfp_flags: The gfp flags to use for ttm_tt_swapout() */
>   	gfp_t gfp_flags;
> -
> +	/** @hit_low: Whether we should attempt to swap BO's with low watermark threshold */
> +	/** @evict_low: If we cannot swap a bo when @try_low is false (first pass) */
>   	bool hit_low, evict_low;
>   };
>   


More information about the dri-devel mailing list