[PATCH][next] drm/display: dp: remove duplicated check of ret < 0

Colin Ian King colin.i.king at gmail.com
Tue Apr 22 22:23:30 UTC 2025


There is a redundant duplicated check for the condition of ret < 0 inside
an if block that also checks for ret < 0. The ternary check is always
true, so remove it and replace it with just return err.

Signed-off-by: Colin Ian King <colin.i.king at gmail.com>
---
 drivers/gpu/drm/display/drm_dp_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
index 57828f2b7b5a..af62d99a0d94 100644
--- a/drivers/gpu/drm/display/drm_dp_helper.c
+++ b/drivers/gpu/drm/display/drm_dp_helper.c
@@ -4044,7 +4044,7 @@ int drm_edp_backlight_enable(struct drm_dp_aux *aux, const struct drm_edp_backli
 	if (ret < 0) {
 		drm_dbg_kms(aux->drm_dev, "%s: Failed to write aux backlight mode: %d\n",
 			    aux->name, ret);
-		return ret < 0 ? ret : -EIO;
+		return ret;
 	}
 
 	ret = drm_edp_backlight_set_level(aux, bl, level);
-- 
2.49.0



More information about the dri-devel mailing list