force_alloc in ttm_operation_ctx

Matthew Brost matthew.brost at intel.com
Wed Apr 23 01:58:45 UTC 2025


On Tue, Apr 22, 2025 at 06:48:08PM -0700, Matthew Brost wrote:
> On Wed, Apr 23, 2025 at 09:35:35AM +1000, Dave Airlie wrote:
> > Hey,
> > 
> > Been digging a bit into cgroups stuff and I found this force_alloc
> > flags in the TTM operation context that seemed like I should dig
> > deeper, but I can't see this flag being used anywhere, places set it
> > but I can't spot the consumer of it?
> > 
> 
> A quick grep shows:
> 
> mbrost at lstrano-desk:drm$ grep force_alloc */*.c
> ttm/ttm_bo_vm.c:                        .force_alloc = true
> ttm/ttm_resource.c:             .force_alloc = true
> 
> We have this wired in xe_bo_evict() too but always set it to false at
> the caller.
> 

Ah, I should read better. Yea, this appears to be unused, only set.

git format-patch -1 c44dfe4de0539

This show when this flag was changed to a bool there was one consumer of
this flag but that user has since been removed. My guess is this had a
use case, that use case changed, and the flag was failed to be removed.
We can probably just remove it since there are no consumers of this.

Matt

> Matt
> 
> > Is there some out of tree patch or something currently being
> > upstreamed to use it?
> > 
> > Dave.


More information about the dri-devel mailing list