[PATCH v3 8/8] drm/msm/dpu: drop now-unused condition for has_legacy_ctls
Jessica Zhang
quic_jesszhan at quicinc.com
Wed Apr 30 00:42:52 UTC 2025
On 3/6/2025 10:24 PM, Dmitry Baryshkov wrote:
> From: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>
> Now as we have dropped the DPU_CTL_SPLIT_DISPLAY from DPU >= 5.0
> configuration, drop the rm->has_legacy_ctl condition which short-cutted
> the check for those platforms.
>
> Suggested-by: Marijn Suijten <marijn.suijten at somainline.org>
> Reviewed-by: Marijn Suijten <marijn.suijten at somainline.org>
> Tested-by: Neil Armstrong <neil.armstrong at linaro.org> # on SM8550-QRD
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
Reviewed-by: Jessica Zhang <quic_jesszhan at quicinc.com>
> ---
>
> Note, it is imposible to reoder commits in any other sensible way. The
> DPU_CTL_SPLIT_DISPLAY can not be dropped before the patch that enables
> single-CTL support.
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> index c72b968d58a65960605456e752278def2a21df7b..2e296f79cba1437470eeb30900a650f6f4e334b6 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> @@ -466,8 +466,7 @@ static int _dpu_rm_reserve_ctls(
>
> DPU_DEBUG("ctl %d caps 0x%lX\n", j + CTL_0, features);
>
> - if (rm->has_legacy_ctls &&
> - needs_split_display != has_split_display)
> + if (needs_split_display != has_split_display)
> continue;
>
> ctl_idx[i] = j;
>
More information about the dri-devel
mailing list