[PATCH v5 04/10] ref_tracker: allow pr_ostream() to print directly to a seq_file

Jeff Layton jlayton at kernel.org
Wed Apr 30 02:18:01 UTC 2025


On Tue, 2025-04-29 at 16:27 -0700, Jakub Kicinski wrote:
> On Mon, 28 Apr 2025 11:26:27 -0700 Jeff Layton wrote:
> > Allow pr_ostream to also output directly to a seq_file without an
> > intermediate buffer.
> > 
> > Reviewed-by: Andrew Lunn <andrew at lunn.ch>
> > Signed-off-by: Jeff Layton <jlayton at kernel.org>
> 
> lib/ref_tracker.c:316:12: warning: unused function 'ref_tracker_dir_seq_print' [-Wunused-function]
>   316 | static int ref_tracker_dir_seq_print(struct ref_tracker_dir *dir, struct seq_file *seq)
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~

The caller ends up being added in patch #6. I think the only thing I
can do here to silence this is to squash this patch into that one.

I kind of don't like doing that here because I think the patches are
conceptually separate, and it'll make for a rather large patch.

Let me know what you prefer.

Thanks,
-- 
Jeff Layton <jlayton at kernel.org>


More information about the dri-devel mailing list