[PATCH next] drm/st7571-i2c: Fix IS_ERR() vs NULL checks in probe()
Javier Martinez Canillas
javierm at redhat.com
Wed Apr 30 13:00:30 UTC 2025
Javier Martinez Canillas <javierm at redhat.com> writes:
> Dan Carpenter <dan.carpenter at linaro.org> writes:
>
> Hello Dan,
>
>> The devm_kzalloc() function returns NULL on failure, not error pointers.
>> Also printing an error message for kmalloc() failures is against kernel
>> style so just return -ENOMEM without printing a message. (Kmalloc
>> already prints a message).
>>
>> Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD controller")
>> Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org>
>> ---
>
> Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
>
Pushed to drm-misc (drm-misc-next). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
More information about the dri-devel
mailing list