[PATCH] drm/drm_bridge: Document 'connector' parameter in drm_bridge_detect()
sukrut heroorkar
hsukrut3 at gmail.com
Mon Aug 4 21:24:58 UTC 2025
Hi Laurent,
On Sun, Aug 3, 2025 at 6:56 PM Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
>
> On Sat, Aug 02, 2025 at 06:13:05PM +0200, Sukrut Heroorkar wrote:
> > drm: drm_bridge: fix missing parameter documentation
> >
> > The function documentation was missing description for the
> > parameter 'connector'.
> >
> > Add missing function parameter documentation for drm_bridge_detect()
> > to fix kernel-doc warnings.
> >
> > Warning: drivers/gpu/drm/drm_bridge.c:1241 function parameter 'connector' not described in 'drm_bridge_detect'
> >
>
> A Fixes: tag would be nice.
>
> > Signed-off-by: Sukrut Heroorkar <hsukrut3 at gmail.com>
> > ---
> > drivers/gpu/drm/drm_bridge.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> > index dd45d9b504d8..387a3b6cda54 100644
> > --- a/drivers/gpu/drm/drm_bridge.c
> > +++ b/drivers/gpu/drm/drm_bridge.c
> > @@ -1227,6 +1227,7 @@ EXPORT_SYMBOL(drm_atomic_bridge_chain_check);
> > /**
> > * drm_bridge_detect - check if anything is attached to the bridge output
> > * @bridge: bridge control structure
> > + * @connector: connector associated with the bridge
>
> "associated with the bridge" isn't very clear.
>
> > *
> > * If the bridge supports output detection, as reported by the
> > * DRM_BRIDGE_OP_DETECT bridge ops flag, call &drm_bridge_funcs.detect for the
>
> --
> Regards,
>
> Laurent Pinchart
Thanks for the review.
I will send a V2 shortly with updated connector description and Fixes
tag, as suggested.
More information about the dri-devel
mailing list