[PATCH] drm/mediatek: fix device leaks at bind
CK Hu (胡俊光)
ck.hu at mediatek.com
Wed Aug 6 07:13:45 UTC 2025
On Tue, 2025-07-22 at 11:27 +0200, Johan Hovold wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>
>
> Make sure to drop the references to the sibling platform devices and
> their child drm devices taken by of_find_device_by_node() and
> device_find_child() when initialising the driver data during bind().
Reviewed-by: CK Hu <ck.hu at mediatek.com>
>
> Fixes: 1ef7ed48356c ("drm/mediatek: Modify mediatek-drm for mt8195 multi mmsys support")
> Cc: stable at vger.kernel.org # 6.4
> Cc: Nancy.Lin <nancy.lin at mediatek.com>
> Signed-off-by: Johan Hovold <johan at kernel.org>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 7c0c12dde488..33b83576af7e 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -395,10 +395,12 @@ static bool mtk_drm_get_all_drm_priv(struct device *dev)
> continue;
>
> drm_dev = device_find_child(&pdev->dev, NULL, mtk_drm_match);
> + put_device(&pdev->dev);
> if (!drm_dev)
> continue;
>
> temp_drm_priv = dev_get_drvdata(drm_dev);
> + put_device(drm_dev);
> if (!temp_drm_priv)
> continue;
>
> --
> 2.49.1
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20250806/f0beb8b6/attachment-0001.htm>
More information about the dri-devel
mailing list