[PATCH 6/9 v2] drm/i915/display: Remove outdated struct_mutex comments
Rodrigo Vivi
rodrigo.vivi at intel.com
Fri Aug 8 14:39:00 UTC 2025
On Thu, Aug 07, 2025 at 02:02:05PM -0300, Luiz Otavio Mello wrote:
> The struct_mutex will be removed from the DRM subsystem, as it was a
> legacy BKL that was only used by i915 driver. After review, it was
> concluded that its usage was no longer necessary
>
> This patch update a comment about struct_mutex in i915/display, in order
> to prevent future misunderstandings.
>
> * intel_fbc.c: Removed the statement that intel_fbc->lock is the inner
> lock when overlapping with struct_mutex, since struct_mutex is no
> longer used anywhere in the driver.
>
> Signed-off-by: Luiz Otavio Mello <luiz.mello at estudante.ufscar.br>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fbc.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index d4c5deff9cbe..aaaabba77b88 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -98,11 +98,7 @@ struct intel_fbc {
> struct intel_display *display;
> const struct intel_fbc_funcs *funcs;
>
> - /*
> - * This is always the inner lock when overlapping with
> - * struct_mutex and it's the outer lock when overlapping
> - * with stolen_lock.
> - */
> + /* This is always the outer lock when overlapping with stolen_lock */
> struct mutex lock;
> unsigned int busy_bits;
>
> --
> 2.50.1
>
More information about the dri-devel
mailing list