[RFC PATCH 1/8] drm: writeback: Refactor drm_writeback_connector structure

[Kandpal, Suraj]

> >  static const char *
> > @@ -187,7 +189,8 @@ static int __drm_writeback_connector_init(struct
> drm_device *dev,
> >  					  struct drm_encoder *enc, const u32
> *formats,
> >  					  int n_formats)
> >  {
> > -	struct drm_connector *connector = &wb_connector->base;
> > +	struct drm_connector *connector =
> > +		drm_writeback_to_connector(wb_connector);
> >  	struct drm_mode_config *config = &dev->mode_config;
> >  	struct drm_property_blob *blob;
> >  	int ret = create_writeback_properties(dev); @@ -269,7 +272,8 @@ int
> > drm_writeback_connector_init(struct drm_device *dev,
> >  				 struct drm_encoder *enc,
> >  				 const u32 *formats, int n_formats)  {
> > -	struct drm_connector *connector = &wb_connector->base;
> > +	struct drm_connector *connector =
> > +		drm_writeback_to_connector(wb_connector);
> 
> Please pass drm_connector instead (to all init functions). It would make more
> sense.

Was thinking around the same lines too let's see how other react to this RFC series.

Regards,
Suraj Kandpal

> 
> >  	int ret;
> >
> >  	ret = drm_connector_init(dev, connector, con_funcs, @@ -339,7 +343,8
> > @@ int drmm_writeback_connector_init(struct drm_device *dev,
> >  				  struct drm_encoder *enc,
> >  				  const u32 *formats, int n_formats)  {
> > -	struct drm_connector *connector = &wb_connector->base;
> > +	struct drm_connector *connector =
> > +		drm_writeback_to_connector(wb_connector);
> >  	int ret;
> >
> >  	ret = drmm_connector_init(dev, connector, con_funcs,
> 
> --
> With best wishes
> Dmitry