[PATCH] drm/rockchip: vop2: move clk-disable into its own function
Heiko Stuebner
heiko at sntech.de
Tue Aug 12 15:01:43 UTC 2025
Right now vop2_enable calls vop2_core_clks_prepare_enable to handle the
vop clocks, but vop2_disable directly disables the clocks.
Not nice from a symmetry point of view and also if we ever need to disable
the clocks elsewhere, this would become a problem, so move clock disable
into its own function as well.
Signed-off-by: Heiko Stuebner <heiko at sntech.de>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 07ea2d2cf6d6..827ce440026c 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -785,6 +785,13 @@ static int vop2_core_clks_prepare_enable(struct vop2 *vop2)
return ret;
}
+static void vop2_core_clks_disable_unprepare(struct vop2 *vop2)
+{
+ clk_disable_unprepare(vop2->pclk);
+ clk_disable_unprepare(vop2->aclk);
+ clk_disable_unprepare(vop2->hclk);
+}
+
static void rk3588_vop2_power_domain_enable_all(struct vop2 *vop2)
{
u32 pd;
@@ -867,9 +874,7 @@ static void vop2_disable(struct vop2 *vop2)
regcache_drop_region(vop2->map, 0, vop2_regmap_config.max_register);
- clk_disable_unprepare(vop2->pclk);
- clk_disable_unprepare(vop2->aclk);
- clk_disable_unprepare(vop2->hclk);
+ vop2_core_clks_disable_unprepare(vop2);
}
static bool vop2_vp_dsp_lut_is_enabled(struct vop2_video_port *vp)
--
2.47.2
More information about the dri-devel
mailing list