PATCH[1/1] DRM_GPUVM.C : htmldoc error due to multi-line code inside comment

Jani Nikula jani.nikula at linux.intel.com
Wed Aug 13 10:29:55 UTC 2025


On Tue, 12 Aug 2025, Sidharth Seela <sidharthseela at gmail.com> wrote:
> Dear Maintainers,
> This is my first patch, please bear with me.
> I request you to suggest if it can be better.
> Your time is appreciated.

A simpler fix is already on the list [1].

BR,
Jani.


[1] https://lore.kernel.org/r/20250810150706.305040-1-rampxxxx@gmail.com

> ---------------------------------------------------------------------------
> commit 4ed9c00376c616cdbfb978b5fd76911cccd63b26
> Author:     Sidharth Seela <sid at y740.local>
> AuthorDate: Tue Aug 12 15:56:03 2025 +0530
> Commit:     Sidharth Seela <sid at y740.local>
> CommitDate: Tue Aug 12 15:56:03 2025 +0530
>
>     cleaned up errors stemming for multiline text
> ---
>  drivers/gpu/drm/drm_gpuvm.c | 50 ++++++++++++++++++-------------------
>  1 file changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
> index bbc7fecb6f4a..cf49dbfcec91 100644
> --- a/drivers/gpu/drm/drm_gpuvm.c
> +++ b/drivers/gpu/drm/drm_gpuvm.c
> @@ -2432,31 +2432,31 @@ static const struct drm_gpuvm_ops lock_ops = {
>   *
>   * The expected usage is:
>   *
> - *    vm_bind {
> - *        struct drm_exec exec;
> - *
> - *        // IGNORE_DUPLICATES is required, INTERRUPTIBLE_WAIT is recommended:
> - *        drm_exec_init(&exec, IGNORE_DUPLICATES | INTERRUPTIBLE_WAIT, 0);
> - *
> - *        drm_exec_until_all_locked (&exec) {
> - *            for_each_vm_bind_operation {
> - *                switch (op->op) {
> - *                case DRIVER_OP_UNMAP:
> - *                    ret = drm_gpuvm_sm_unmap_exec_lock(gpuvm,
> &exec, op->addr, op->range);
> - *                    break;
> - *                case DRIVER_OP_MAP:
> - *                    ret = drm_gpuvm_sm_map_exec_lock(gpuvm, &exec,
> num_fences,
> - *                                                     op->addr, op->range,
> - *                                                     obj, op->obj_offset);
> - *                    break;
> - *                }
> - *
> - *                drm_exec_retry_on_contention(&exec);
> - *                if (ret)
> - *                    return ret;
> - *            }
> - *        }
> - *    }
> + * *   vm_bind {
> + * *       struct drm_exec exec;
> + * *
> + * *       // IGNORE_DUPLICATES is required, INTERRUPTIBLE_WAIT is recommended:
> + * *       drm_exec_init(&exec, IGNORE_DUPLICATES | INTERRUPTIBLE_WAIT, 0);
> + * *
> + * *       drm_exec_until_all_locked (&exec) {
> + * *           for_each_vm_bind_operation {
> + * *               switch (op->op) {
> + * *               case DRIVER_OP_UNMAP:
> + * *                   ret = drm_gpuvm_sm_unmap_exec_lock(gpuvm,
> &exec, op->addr, op->range);
> + * *                   break;
> + * *               case DRIVER_OP_MAP:
> + * *                   ret = drm_gpuvm_sm_map_exec_lock(gpuvm, &exec,
> num_fences,
> + * *                                                    op->addr, op->range,
> + * *                                                    obj, op->obj_offset);
> + * *                   break;
> + * *               }
> + * *
> + * *               drm_exec_retry_on_contention(&exec);
> + * *               if (ret)
> + * *                   return ret;
> + * *           }
> + * *       }
> + * *   }
>   *
>   * This enables all locking to be performed before the driver begins modifying
>   * the VM.  This is safe to do in the case of overlapping DRIVER_VM_BIND_OPs,
> --
> 2.39.5
> signed-off-by:Sidharth Seela<sidharthseela at gmail.com>

-- 
Jani Nikula, Intel


More information about the dri-devel mailing list