[PATCH 12/12] Documentation: Update the todo

[Anusha Srivatsa]

On Thu, Feb 6, 2025 at 2:57 AM Thomas Zimmermann <tzimmermann at suse.de>
wrote:

> Hi
>
>
> Am 05.02.25 um 21:08 schrieb Anusha Srivatsa:
> > Update the Documentation to be more precise.
> >
> > v2: Update for clarity
> >
> > Cc: Thomas Zimmermann <tzimmermann at suse.de>
> > Signed-off-by: Anusha Srivatsa <asrivats at redhat.com>
> > ---
> >   Documentation/gpu/todo.rst | 12 ++++++------
> >   1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> > index
> 256d0d1cb2164bd94f9b610a751b907834d96a21..03fcd086889acbd1294669b260292ffc79e97e2f
> 100644
> > --- a/Documentation/gpu/todo.rst
> > +++ b/Documentation/gpu/todo.rst
> > @@ -441,13 +441,13 @@ Contact: Thomas Zimmermann <tzimmermann at suse.de>
> >
> >   Level: Intermediate
> >
> > -Request memory regions in all drivers
> > --------------------------------------
> > +Request memory regions in all fbdev drivers
> > +--------------------------------------------
> >
> > -Go through all drivers and add code to request the memory regions that
> the
> > -driver uses. This requires adding calls to request_mem_region(),
> > -pci_request_region() or similar functions. Use helpers for managed
> cleanup
> > -where possible.
> > +Old/ancient fbdev drivers do not request their memory properly.
> > +Go through these drivers and add code to request the memory regions
> that the
> > +driver uses. Problematic areas include hardware that has exclusive
> ranges like
> > +VGA. VGA16fb does not request the range as it is expected.
>
> I'd keep both, old and new text, and turn them into a single paragraph.
> The old text explains what to do and the new text gives examples.
>
>
Sure. Waiting for one final patch to be reviewed(patch 11). With that, I
will make the changes you suggested and re-roll the series.

Thanks for the feedback!

Anusha

> Best regards
> Thomas
> >
> >   Drivers are pretty bad at doing this and there used to be conflicts
> among
> >   DRM and fbdev drivers. Still, it's the correct thing to do.
> >
>
> --
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20250206/418e00c0/attachment.htm>