[PATCH] drm/tests: Drop drm_kunit_helper_acquire_ctx_alloc()
Dmitry Baryshkov
dmitry.baryshkov at linaro.org
Fri Feb 7 03:22:53 UTC 2025
On Thu, Feb 06, 2025 at 05:05:48PM +0100, Maxime Ripard wrote:
> lockdep complains when a lock is released in a separate function the
> lock is taken in, and it's even worse in the kunit case since the kunit
> actions run in a separate thread.
>
> This means that drm_kunit_helper_acquire_ctx_alloc() just cannot work as
> it's supposed to, so let's just get rid of it.
>
> Suggested-by: Simona Vetter <simona.vetter at ffwll.ch>
> Signed-off-by: Maxime Ripard <mripard at kernel.org>
> ---
> drivers/gpu/drm/tests/drm_atomic_state_test.c | 24 +-
> .../drm/tests/drm_hdmi_state_helper_test.c | 242 +++++++++++-------
> drivers/gpu/drm/tests/drm_kunit_helpers.c | 41 ---
> .../gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 46 ++--
> include/drm/drm_kunit_helpers.h | 2 -
> 5 files changed, 184 insertions(+), 171 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
--
With best wishes
Dmitry
More information about the dri-devel
mailing list