[PATCH v7 5/6] drm/xe/xe_hw_engine: Update xe_hw_engine capture for debugfs/gt_reset

[Dong, Zhanjun]

If rename is the only change in next revision, that's fine to me.

Reviewed-by: Zhanjun Dong <zhanjun.dong at intel.com>

On 2025-02-11 12:34 p.m., Teres Alexis, Alan Previn wrote:
> On Mon, 2025-02-10 at 15:32 -0800, Teres Alexis, Alan Previn wrote:
>> xe_hw_engine_print is called by debugfs to do an immediate raw
>> --- a/drivers/gpu/drm/xe/xe_guc_capture_snapshot_types.h
>> +++ b/drivers/gpu/drm/xe/xe_guc_capture_snapshot_types.h
>> @@ -12,7 +12,11 @@
>>   struct guc_mmio_reg;
>>   
>>   enum xe_guc_capture_snapshot_source {
>> -       XE_ENGINE_CAPTURE_SOURCE_MANUAL,
>> +       /* KMD captured engine registers when job timeout is detected */
>> +       XE_ENGINE_CAPTURE_SOURCE_MANUAL_JOB,
>> +       /* KMD captured raw engine registers without any job association */
>> +       XE_ENGINE_CAPTURE_SOURCE_MANUAL_RAW,
>> +       /* GUC-FW captured engine registers before workload was killed */
>>          XE_ENGINE_CAPTURE_SOURCE_GUC
>>   };
>>   
> alan: some offline feedback was given to rename the enum to match:
> "enum xe_guc_capture_snapshot_source" -> "enum xe_engine_capture_source"
> 
>