[PATCH v7 6/6] drm/xe/guc: Update comments on GuC-Err-Capture flows

Teres Alexis, Alan Previn alan.previn.teres.alexis at intel.com
Wed Feb 12 18:54:10 UTC 2025


On Tue, 2025-02-11 at 18:09 -0500, Dong, Zhanjun wrote:
> 
> > 
alan:snip
> >    *
> > - * User Sysfs / Debugfs
> > - * --------------------
> > - *      --> xe_devcoredump_read->
> > + * User Devcoredump Sysfs
> > + * ----------------------
> > + *      --> xe_devcoredump_read-> (user cats devcoredump)
> >    *             L--> xxx_snapshot_print
> >    *                    L--> xe_hw_engine_print --> xe_hw_engine_snapshot_print
> >    *                          L--> xe_guc_capture_snapshot_print
>                                 L--> hw_engine_snapshot_capture
>                                      xe_guc_capture_snapshot_manual_hwe
>                                      // The new function which do manual capture without job
> And, for debugfs, it did not calls xe_devcoredump_read...
> instead, by "hw_engines". Shall we mention debugfs call 
> xe_hw_engine_print directly?
> 
> Other than that, LGTM
> Reviewed-by: Zhanjun Dong <zhanjun.dong at intel.com>
> 

alan: thanks - i will add a new section to differentiate
"User->sysfs devcore dump" vs "User->debugfs engine dump" - both with similiar endpoints ending with
xe_hw_engine_snapshot_print->xe_guc_capture_snapshot_print


More information about the dri-devel mailing list