[PATCH] bus: mhi: host: Avoid possible uninitialized fw_load_type

[Jeffrey Hugo]

On 2/14/2025 10:34 AM, Manivannan Sadhasivam wrote:
> On Fri, Feb 14, 2025 at 09:21:09AM -0700, Jeffrey Hugo wrote:
>> If mhi_fw_load_handler() bails out early because the EE is not capable
>> of loading firmware, we may reference fw_load_type in cleanup which is
>> uninitialized at this point. The cleanup code checks fw_load_type as a
>> proxy for knowing if fbc_image was allocated and needs to be freed, but
>> we can directly test for that. This avoids the possible uninitialized
>> access and appears to be clearer code.
>>
>> Reported-by: Dan Carpenter <dan.carpenter at linaro.org>
>> Closes: https://lore.kernel.org/all/e3148ac4-7bb8-422d-ae0f-18a8eb15e269@stanley.mountain/
>> Fixes: f88f1d0998ea ("bus: mhi: host: Add a policy to enable image transfer via BHIe in PBL")
> 
> The best thing would be to squash this fix into the offending commit as the
> fixes tag would become meaningless once merged upstream.

I see your point, however the offending commit is already part of a pull 
request. I think we've missed the window for squashing.

Thank you for the very quick review.

-Jeff