[PATCH v2] fbdev: lcdcfb: add missing device_remove_file()
Shixiong Ou
oushixiong1025 at 163.com
Wed Feb 19 07:40:24 UTC 2025
在 2025/2/19 14:47, Arnd Bergmann 写道:
> On Sat, Feb 8, 2025, at 10:29, oushixiong1025 at 163.com wrote:
>> From: Shixiong Ou <oushixiong at kylinos.cn>
>>
>> 1. The device_remove_file() need to be called when driver is removing.
>> 2. The device_remove_file() need to be called if the call to
>> device_create_file() fails.
> This should probably use device_add_group() instead of
> individual files to simplify both creation and removal.
> It would also avoid the bug you introduced that gcc warns
> about.
>
> Arnd
Thank you for your suggestion. I will incorporate your advice and resend a patch.
Thanks and Regards,
Shixiong Ou.
More information about the dri-devel
mailing list