[PATCH v3 3/3] drm/tiny: add driver for Apple Touch Bars in x86 Macs

[Aditya Garg]

> On 24 Feb 2025, at 5:13 PM, andriy.shevchenko at linux.intel.com wrote:
> 
> On Mon, Feb 24, 2025 at 11:20:12AM +0000, Aditya Garg wrote:
>> 
>>> 
>>> It would be nice to see the difference in the code generation for the all
>>> __packed vs. only those that require it.
>>> 
>>>> At least it's clear then
>>>> what happens. And if your hardware requires this, you can't do much anyway.
>>> 
>>> One aspect (member level alignment) is clear but the other is not
>>> (object level alignment). I dunno if it makes sense to be pedantic about this,
>>> but would like to see the binary outcome asked for.
>> 
>> Hex dump of the compiled binary:
> 
> Oh, sorry I wasn't clear. We have a script called bloat-o-meter for these
> purposes. Please, run it with old and new binaries as parameters and share the
> output.

aditya at MacBook:~/linux$ ./scripts/bloat-o-meter $PACKED $UNPACKED
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
Function                                     old     new   delta
Total: Before=13286, After=13286, chg +0.00%

aditya at MacBook:~/linux$ ./scripts/bloat-o-meter $PACKED $UNPACKED -c
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
Function                                     old     new   delta
Total: Before=4957, After=4957, chg +0.00%
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
Data                                         old     new   delta
Total: Before=1560, After=1560, chg +0.00%
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
RO Data                                      old     new   delta
Total: Before=6769, After=6769, chg +0.00%

aditya at MacBook:~/linux$ ./scripts/bloat-o-meter $PACKED $UNPACKED -d
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
Data                                         old     new   delta
Total: Before=8329, After=8329, chg +0.00%

aditya at MacBook:~/linux$ ./scripts/bloat-o-meter $PACKED $UNPACKED -t
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
Function                                     old     new   delta
Total: Before=4957, After=4957, chg +0.00%

> 
> --
> With Best Regards,
> Andy Shevchenko
> 
>