[PATCH] drm/virtio: Lock the VGA resources during initialization

Kasireddy, Vivek vivek.kasireddy at intel.com
Fri Jan 10 06:00:43 UTC 2025


Hi Dmitry,

> Subject: Re: [PATCH] drm/virtio: Lock the VGA resources during initialization
> 
> On 12/11/24 09:43, Vivek Kasireddy wrote:
> > +static int __init virtio_gpu_driver_init(void)
> > +{
> > +	struct pci_dev *pdev;
> > +	int ret;
> > +
> > +	pdev = pci_get_device(PCI_VENDOR_ID_REDHAT_QUMRANET,
> > +			      PCI_DEVICE_ID_VIRTIO_GPU,
> > +			      NULL);
> > +	if (!pdev)
> > +		return -ENODEV;
> 
> I realized that we likely shouldn't assume that virtio-gpu is always on
> PCI bus. It could be MMIO device, AFAICT. And then we shouldn't error
> out if PCI not found.
Yeah, you are right. I was not aware that virtio-gpu can be run in MMIO mode
with Qemu M68K. I'll send out a patch to fix this next week.

Thanks,
Vivek

> 
> --
> Best regards,
> Dmitry


More information about the dri-devel mailing list