[PATCH v4] drm/bridge: it6505: fix HDCP V match check is not performed correctly

Dmitry Baryshkov dmitry.baryshkov at linaro.org
Tue Jan 21 10:19:16 UTC 2025


On Tue, Jan 21, 2025 at 03:01:51PM +0800, Hermes Wu via B4 Relay wrote:
> From: Hermes Wu <Hermes.wu at ite.com.tw>
> 
> Fix a typo where V compare incorrectly compares av[] with av[] itself,
> which can result in HDCP failure.
> 
> The loop of V compare is expected to iterate for 5 times
> which compare V array form av[0][] to av[4][].
> It should check loop counter reach the last statement "i == 5"
> before return true
> 
> Fixes: 0989c02c7a5c ("drm/bridge: it6505: fix HDCP CTS compare V matching")
> Signed-off-by: Hermes Wu <Hermes.wu at ite.com.tw>
> ---
> Changes in v4:
> - Fix a typo where V compare incorrectly compares av[] with av[] itself
> - Link to v3: https://lore.kernel.org/r/20250109-fix-hdcp-v-comp-v3-1-1258edb249ab@ite.com.tw
> 
> Changes in v3:
> - The V value compare loop from i = 0 to i = 4 and shall exit with i == 5 
>   if all V element matches
> - Link to v2: https://lore.kernel.org/r/20250109-fix-hdcp-v-comp-v2-1-7dce0a59523f@ite.com.tw
> 
> Changes in v2:
> - pull the check of statment "i" out of V value check loop 
> - Link to v1: https://lore.kernel.org/r/20250108-fix-hdcp-v-comp-v1-1-9404811825cd@ite.com.tw
> ---
>  drivers/gpu/drm/bridge/ite-it6505.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>

-- 
With best wishes
Dmitry


More information about the dri-devel mailing list