[RFC v3 05/18] pmdomain: thead: Add power-domain driver for TH1520

Krzysztof Kozlowski krzk at kernel.org
Wed Jan 22 11:36:42 UTC 2025


On 22/01/2025 12:26, Michal Wilczynski wrote:
>>>
>>> These power-domain constants are defined by the AON firmware protocol,
>>> which dictates the exact IDs (e.g., 1 for NPU). They are not just array
>>> indices; we must use these specific values to communicate with the
>>> firmware correctly. Using array indices starting with 1 would be
>>> unusual.
>>
>> Then that's a no. Binding constants do not represent values used by your
>> hardware. The binding constant should start from 0.
> 
> Would it be a problem if those overlapped ? There is one more value that

No, I just don't care about hardware constants here. Use the bindings
constants in your driver at least as abstract IDs or these are not
suitable for bindings.

Best regards,
Krzysztof


More information about the dri-devel mailing list