[V7 23/45] drm/amd/display: Ignore deprecated props when plane_color_pipeline set

Simon Ser contact at emersion.fr
Thu Jan 23 20:29:54 UTC 2025


On Wednesday, January 22nd, 2025 at 22:05, Harry Wentland <harry.wentland at amd.com> wrote:

> On 2025-01-15 02:56, Simon Ser wrote:
> 
> > Is this "ignore" something we could do at the core DRM level, instead
> > of doing it in all drivers? e.g. by silently ignoring user-space requests
> > to set the property?
> 
> I think it'd be better to reject setting the property. The problem
> is that a client without the COLOR_PIPELINE client cap might have
> set these properties and we'll want to ignore that when we are
> programming a commit with a color pipeline.
> 
> Since it's the drivers that decide on the programming based on
> the states it's up to each driver to ignore the deprecated
> properties.

Right. Maybe the "plane_color_pipeline" field could be renamed to
e.g. "ignore_plane_color_space_and_encoding" to make it clearer what
drivers are expected to do based on this? Either way, sounds good.


More information about the dri-devel mailing list