[PATCH v2] drm/bridge: Use devm_platform_get_and_ioremap_resource()

Maxime Ripard mripard at kernel.org
Sun Jan 26 16:37:11 UTC 2025


On Wed, Jan 22, 2025 at 10:56:00AM +0800, oushixiong1025 at 163.com wrote:
> From: Shixiong Ou <oushixiong at kylinos.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single call to
> devm_platform_get_and_ioremap_resource().
> 
> Signed-off-by: Shixiong Ou <oushixiong at kylinos.cn>
> ---
> V1 -> V2: Add Missing commit message.
> 
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +---
>  drivers/gpu/drm/bridge/microchip-lvds.c            | 5 ++---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c          | 3 +--
>  3 files changed, 4 insertions(+), 8 deletions(-)

Please split it into one patch per driver.

> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index bfa88409a7ff..284fd186eb5f 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1605,9 +1605,7 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
>  		return ERR_CAST(dp->clock);
>  	}
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> -	dp->reg_base = devm_ioremap_resource(&pdev->dev, res);
> +	dp->reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);

Why do we need to use devm_platform_get_and_ioremap_resource() over
devm_platform_ioremap_resource()?

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 273 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20250126/3e2c596e/attachment.sig>


More information about the dri-devel mailing list