[PATCH 1/2] dt-bindings: display/msm/dsi-phy: Add header with exposed clock IDs
Dmitry Baryshkov
dmitry.baryshkov at linaro.org
Mon Jan 27 13:56:03 UTC 2025
On Mon, Jan 27, 2025 at 02:21:04PM +0100, Krzysztof Kozlowski wrote:
> DSI phys, from earliest (28 nm) up to newest (3 nm) generation, provide
> two clocks. The respective clock ID is used by drivers and DTS, so it
> should be documented as explicit ABI.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>
> ---
>
> Patch for Display tree, although with Ack from clock.
> ---
> .../devicetree/bindings/display/msm/dsi-phy-common.yaml | 2 ++
> MAINTAINERS | 1 +
> include/dt-bindings/clock/qcom,dsi-phy-28nm.h | 9 +++++++++
> 3 files changed, 12 insertions(+)
> create mode 100644 include/dt-bindings/clock/qcom,dsi-phy-28nm.h
>
> diff --git a/include/dt-bindings/clock/qcom,dsi-phy-28nm.h b/include/dt-bindings/clock/qcom,dsi-phy-28nm.h
> new file mode 100644
> index 000000000000..ab94d58377a1
> --- /dev/null
> +++ b/include/dt-bindings/clock/qcom,dsi-phy-28nm.h
I think this should be dt-bindings/phy/qcom,foo.h
Other than that LGTM
> @@ -0,0 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +
> +#ifndef _DT_BINDINGS_CLK_QCOM_DSI_PHY_28NM_H
> +#define _DT_BINDINGS_CLK_QCOM_DSI_PHY_28NM_H
> +
> +#define DSI_BYTE_PLL_CLK 0
> +#define DSI_PIXEL_PLL_CLK 1
> +
> +#endif
> --
> 2.43.0
>
--
With best wishes
Dmitry
More information about the dri-devel
mailing list