[PATCH v3 2/2] staging: fbtft: cleanup error handling in fbtft_framebuffer_alloc()
Dan Carpenter
dan.carpenter at linaro.org
Tue Jul 1 14:22:30 UTC 2025
On Tue, Jul 01, 2025 at 10:03:50AM +0300, Andy Shevchenko wrote:
> On Tue, Jul 1, 2025 at 8:14 AM Greg KH <gregkh at linuxfoundation.org> wrote:
> > On Tue, Jul 01, 2025 at 12:47:22AM +0530, Abdun Nihaal wrote:
> > > On Mon, Jun 30, 2025 at 07:16:38PM +0200, Greg KH wrote:
> > > > This patch does not apply to my tree, can you rebase and resend?
> > >
> > > I think you have added both the V1 patch and this current V3 patchset to
> > > your tree, that's why this patch does not apply.
> > >
> > > Commit eb2cb7dab60f ("staging: fbtft: fix potential memory leak in fbtft_framebuffer_alloc()")
> > > on staging-testing is an older version of this patchset, and so it has to be dropped.
> >
> > I can't "drop" patches as my tree can not be rebased. Can you send a
> > fix-up patch instead, OR a revert?
>
> I think the cleaner solution will be revert and v3 patches together as
> v4. Abdun, can you do that?
>
I'm reading my email in the wrong order today. I thought Abdun came
up with the revert idea on his own instead of you and Greg suggesting
it...
This isn't a case where we revert. The patch we applied was acceptable
quality and it worked fine. Just do the additional cleanup on the top.
regards,
dan carpenter
More information about the dri-devel
mailing list