[PATCH] drm/bridge: analogix_dp: Use devm_drm_bridge_alloc() API

[Maxime Ripard]

On Tue, Jul 01, 2025 at 04:02:19PM +0200, Luca Ceresoli wrote:
> Hello Marek, Maxime,
> 
> thanks Marek for spotting the issue and sending a patch!
> 
> On Mon, 30 Jun 2025 18:44:24 +0200
> Maxime Ripard <mripard at kernel.org> wrote:
> 
> > > @@ -1643,7 +1625,7 @@ int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm_dev)
> > >  		return ret;
> > >  	}
> > >  
> > > -	ret = analogix_dp_create_bridge(drm_dev, dp);
> > > +	ret = drm_bridge_attach(dp->encoder, &dp->bridge, NULL, 0);
> > >  	if (ret) {
> > >  		DRM_ERROR("failed to create bridge (%d)\n", ret);
> > >  		goto err_unregister_aux;  
> > 
> > It looks like you don't set bridge->driver_private anymore. Is it on purpose?
> 
> This looks correct to me. In current code, driver_private is used to
> hold a pointer to the driver private struct (struct
> analogix_dp_device). With devm_drm_bridge_alloc() container_of() is now
> enough, no pointer is needed. With the patch applied, driver_private
> becomes unused.

Then we should remove it from the structure if it's unused.

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 273 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20250701/466f205b/attachment-0001.sig>