[PATCH 06/10] drm/ast: Move struct ast_dramstruct to ast_post.h

Jocelyn Falempe jfalempe at redhat.com
Thu Jul 3 13:10:45 UTC 2025


On 02/07/2025 15:12, Thomas Zimmermann wrote:
> Declare struct ast_dramstruct in ast_post.h and remove its original
> header file.

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfalempe at redhat.com>

> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---
>   drivers/gpu/drm/ast/ast_2000.c        |  2 +-
>   drivers/gpu/drm/ast/ast_2100.c        |  2 +-
>   drivers/gpu/drm/ast/ast_dram_tables.h | 11 -----------
>   drivers/gpu/drm/ast/ast_post.h        |  6 ++++++
>   4 files changed, 8 insertions(+), 13 deletions(-)
>   delete mode 100644 drivers/gpu/drm/ast/ast_dram_tables.h
> 
> diff --git a/drivers/gpu/drm/ast/ast_2000.c b/drivers/gpu/drm/ast/ast_2000.c
> index 099c90e1402f..b2ad2ea5056b 100644
> --- a/drivers/gpu/drm/ast/ast_2000.c
> +++ b/drivers/gpu/drm/ast/ast_2000.c
> @@ -28,8 +28,8 @@
>   
>   #include <linux/delay.h>
>   
> -#include "ast_dram_tables.h"
>   #include "ast_drv.h"
> +#include "ast_post.h"
>   
>   /*
>    * POST
> diff --git a/drivers/gpu/drm/ast/ast_2100.c b/drivers/gpu/drm/ast/ast_2100.c
> index f41c778e02da..ee40f3911ca4 100644
> --- a/drivers/gpu/drm/ast/ast_2100.c
> +++ b/drivers/gpu/drm/ast/ast_2100.c
> @@ -28,8 +28,8 @@
>   
>   #include <linux/delay.h>
>   
> -#include "ast_dram_tables.h"
>   #include "ast_drv.h"
> +#include "ast_post.h"
>   
>   /*
>    * POST
> diff --git a/drivers/gpu/drm/ast/ast_dram_tables.h b/drivers/gpu/drm/ast/ast_dram_tables.h
> deleted file mode 100644
> index 6c191e2c4e6c..000000000000
> --- a/drivers/gpu/drm/ast/ast_dram_tables.h
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef AST_DRAM_TABLES_H
> -#define AST_DRAM_TABLES_H
> -
> -/* DRAM timing tables */
> -struct ast_dramstruct {
> -	u16 index;
> -	u32 data;
> -};
> -
> -#endif
> diff --git a/drivers/gpu/drm/ast/ast_post.h b/drivers/gpu/drm/ast/ast_post.h
> index 314fa0475c79..3a55c32a7eb7 100644
> --- a/drivers/gpu/drm/ast/ast_post.h
> +++ b/drivers/gpu/drm/ast/ast_post.h
> @@ -7,6 +7,12 @@
>   
>   struct ast_device;
>   
> +/* DRAM timing tables */
> +struct ast_dramstruct {
> +	u16 index;
> +	u32 data;
> +};
> +
>   u32 __ast_mindwm(void __iomem *regs, u32 r);
>   void __ast_moutdwm(void __iomem *regs, u32 r, u32 v);
>   



More information about the dri-devel mailing list