[PATCH 08/18] gpu: nova-core: register: add missing doccomments for fixed registers I/O accessors
Alexandre Courbot
acourbot at nvidia.com
Fri Jul 4 07:25:09 UTC 2025
Add the missing doccomments for these accessors, as having a bit of
inline documentation is always helpful.
Signed-off-by: Alexandre Courbot <acourbot at nvidia.com>
---
drivers/gpu/nova-core/regs/macros.rs | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/nova-core/regs/macros.rs b/drivers/gpu/nova-core/regs/macros.rs
index 73ee72a6c7baa7e9d1032ec0da119940b8f1a3f7..60e5e6a2250a9db453a7a648108af6acaa047342 100644
--- a/drivers/gpu/nova-core/regs/macros.rs
+++ b/drivers/gpu/nova-core/regs/macros.rs
@@ -300,6 +300,7 @@ pub(crate) fn [<set_ $field>](mut self, value: $to_type) -> Self {
impl $name {
pub(crate) const OFFSET: usize = $offset;
+ /// Read the register from its address in `io`.
#[inline]
pub(crate) fn read<const SIZE: usize, T>(io: &T) -> Self where
T: ::core::ops::Deref<Target = ::kernel::io::Io<SIZE>>,
@@ -307,6 +308,7 @@ pub(crate) fn read<const SIZE: usize, T>(io: &T) -> Self where
Self(io.read32($offset))
}
+ /// Write the value contained in `self` to the register address in `io`.
#[inline]
pub(crate) fn write<const SIZE: usize, T>(self, io: &T) where
T: ::core::ops::Deref<Target = ::kernel::io::Io<SIZE>>,
@@ -314,6 +316,8 @@ pub(crate) fn write<const SIZE: usize, T>(self, io: &T) where
io.write32(self.0, $offset)
}
+ /// Read the register from its address in `io` and run `f` on its value to obtain a new
+ /// value to write back.
#[inline]
pub(crate) fn alter<const SIZE: usize, T, F>(
io: &T,
--
2.50.0
More information about the dri-devel
mailing list