[PATCH v3 2/3] drm: Add missing struct drm_wedge_task_info kernel doc
Raag Jadav
raag.jadav at intel.com
Fri Jul 4 18:47:50 UTC 2025
On Fri, Jun 27, 2025 at 02:17:14PM -0300, André Almeida wrote:
> Fix the following kernel doc warning:
>
> include/drm/drm_device.h:40: warning: Function parameter or struct member 'pid' not described in 'drm_wedge_task_info'
> include/drm/drm_device.h:40: warning: Function parameter or struct member 'comm' not described in 'drm_wedge_task_info'
>
> Fixes: 183bccafa176 ("drm: Create a task info option for wedge events")
> Reported-by: Stephen Rothwell <sfr at canb.auug.org.au>
> Signed-off-by: André Almeida <andrealmeid at igalia.com>
> ---
> v3: Make it consistent with drm_device member description
> v2: Add Reported-by tag
> ---
> include/drm/drm_device.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_device.h b/include/drm/drm_device.h
> index 08b3b2467c4c..73dd3c5470a4 100644
> --- a/include/drm/drm_device.h
> +++ b/include/drm/drm_device.h
> @@ -35,7 +35,9 @@ struct pci_controller;
> * struct drm_wedge_task_info - information about the guilty task of a wedge dev
> */
> struct drm_wedge_task_info {
> + /** @pid: the pid of the task */
Nit: Can be simply "pid of the task" without initial "the".
> pid_t pid;
> + /** @comm: the command name of the task */
Ditto.
> char comm[TASK_COMM_LEN];
But in any case,
Reviewed-by: Raag Jadav <raag.jadav at intel.com>
More information about the dri-devel
mailing list